align reasoning model params with OpenAI spec & add 'minimal' effort support#652
Open
RaajeevChandran wants to merge 1 commit intoosaurus-ai:mainfrom
Open
align reasoning model params with OpenAI spec & add 'minimal' effort support#652RaajeevChandran wants to merge 1 commit intoosaurus-ai:mainfrom
RaajeevChandran wants to merge 1 commit intoosaurus-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #649 by resolving HTTP 400 error when using OpenAI's reasoning models (o1 and gpt-5-nano) by aligning the request payload with the OpenAI API specification referred from the official OpenAI community
Changes
reasoning_effortparameter for openai.com host (I've ensured backward compatibility fr other providers)temperatureandtop_pfrom the request when an OpenAI reasoning model is detected. Looks like these parameters are forbidden by OpenAI when reasoning features are active.I've also created a new "minimal" effort level in the
OpenAIReasoningProfilefor reasoning models.Behavior change
UI change (screenshots below)
Refactor / chore
Tests
Docs
Test Plan
Checklist
CONTRIBUTING.md